[Freeipa-devel] [PATCH] 067 Silence a compilation warning in ipa_kpasswd

[Martin Kosek]

On Fri, 2011-07-29 at 17:02 +0200, Jakub Hrozek wrote:
> On 07/21/2011 02:53 PM, Martin Kosek wrote:
> > On Thu, 2011-07-21 at 14:40 +0200, Jan Cholasta wrote:
> >> On 20.7.2011 17:10, Jakub Hrozek wrote:
> >>> I was playing with ipa_kpasswd (long story short - I needed it running
> >>> on a non-standard port) and I noticed there was a compilation warning -
> >>> rtag was set but never checked.
> >>>
> >>> Also removes one unused #define.
> >>>
> >>
> >> Found just a minor issue: you use spaces for indentation, but the rest 
> >> of the file uses tabs.
> >>
> >> Honza
> >>
> > 
> > To put my 2 cents in - I don't like throwing the same error message in
> > more places.
> > 
> > When it really ends with this message we wouldn't know the exact spot
> > with the error. IMO it would make the following investigation simpler if
> > we fix this.
> > 
> > Martin
> > 
> 
> A new patch is attached.

ACK and pushed to ipa-2-1.

Martin