[Freeipa-devel] [PATCH] 263 Fixed problem with combobox using Sahi

[Endi Sukma Dewata]

On 9/5/2011 9:51 PM, Adam Young wrote:
> On 09/01/2011 05:24 PM, Endi Sukma Dewata wrote:
>> The IPA.combobox_widget has been temporarily fixed to support automation
>> using Sahi.
>>
>> Ticket #1754
>
> This looks like a reasonable change. I think that most combo-box
> controls would close once you made a persisted change. Any reason not to
> keep this as the long term fix?

With a native drop-down list if you click the same value that you've 
already selected previously the list will close. Our custom combo-box 
was able to replicate this behavior before this change, but it didn't 
work for Sahi.

With this patch if you click the same value again the list will not 
close, you'd have to click the down arrow to close it, so it's is not 
consistent with the native widget.

Although users probably wouldn't see this issue too often, I think it's 
better to keep the custom widget as close as possible to the native widget.

-- 
Endi S. Dewata