[Freeipa-devel] [PATCH, FreeIPA2.1] Review request for platform abstraction refactoring

[Alexander Bokovoy]

On 01.09.2011 22:41, Simo Sorce wrote:
>> I tried on F15, doing ipa-server-install with different options and
>> uninstalling as well, joining another client and removing it later. Of
>> course, more testing is needed too.
> 
> Patches look good, and they mostly work fine on top of master but I got
> this stack trace trying to uninstall:
> 
> 
>         # ipa-client-install --uninstall
>         Unenrolling client from IPA server
>         Unenrolling host failed: Error obtaining initial credentials:
>         Decrypt integrity check failed.
>          
>         Removing Kerberos service principals from /etc/krb5.keytab
>         Disabling client Kerberos and LDAP configurations
>         Restoring client configuration files
>         Traceback (most recent call last):
>         File "/usr/sbin/ipa-client-install", line 1117, in <module>
>         sys.exit(main())
>         File "/usr/sbin/ipa-client-install", line 1099, in main
>         return uninstall(options, env)
>         File "/usr/sbin/ipa-client-install", line 295, in uninstall
>         nslcd = ipaservices.knownservices.nslcd
>         File "/usr/lib/python2.7/site-packages/ipalib/plugable.py", line
>         167, in __getattr__
>         raise AttributeError('no magic attribute %r' % name)
>         AttributeError: no magic attribute 'nslcd'
> 
> 
> If you resolve this issue we should be basically good to go.
Ohh, this was simple typo in ipapython/platform/base.py,
wellknownservices contained nlscd instead of nslcd. And this example
shows how important to work with services as "native" objects -- Python
interpreter will help to protect against such typos in the client code.
Of course, if framework is not broken... :)

Fixed and pushed update into the tree on fedorapeople.

Thanks for the review!
-- 
/ Alexander Bokovoy