[Freeipa-devel] [PATCH] 267 Fixed missing optional field.

[Petr Vobornik]

On 09/10/2011 02:20 AM, Endi Sukma Dewata wrote:
> The optional uid field in user's adder dialog did not appear when
> the link is clicked to show the field. This is a regression introduced
> in the patch for ticket #1648.
>
> The click handler for the link field has been moved into a new closure
> so that the variables point to the correct elements.
>
> Note: the duplicate code in IPA.details_table_section.create() and
> IPA.dialog.create() will be addressed separately in ticket #1394.

ACK

But:
The part of code in details.js is never executed because field.optional 
is never set to true for fields in details facet. As you write, some 
clean-up should be addressed in #1394 or/and in #1696 (to be consistent 
with dialogs).

-- 
Petr Vobornik