[Freeipa-devel] [PATCH] 868 better handling of ipa-pki-proxy.conf

[Rob Crittenden]

Martin Kosek wrote:
> On Fri, 2011-09-09 at 17:41 -0400, Rob Crittenden wrote:
>> - Remove ipa-pki-proxy.conf when IPA is uninstalled
>> - Move file removal to httpinstance.py and use remove_file()
>> - Add a version stanza
>> - Create the file if it doesn't exist on upgraded installs
>>
>> https://fedorahosted.org/freeipa/ticket/1771
>>
>> rob
>
> Both upgrade and new install worked fine. I only find the following
> try..except clause redundant since all exceptions are captured and
> logged in installutils.remove_file:
>
> +        # Remove the configuration files we create
> +        try:
> +            installutils.remove_file("/etc/httpd/conf.d/ipa-rewrite.conf")
> +            installutils.remove_file("/etc/httpd/conf.d/ipa.conf")
> +            installutils.remove_file("/etc/httpd/conf.d/ipa-pki-proxy.conf")
> +        except:
> +            pass
>
> Martin
>

Updated patch attached

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rcrit-868-2-proxy.patch
Type: text/x-patch
Size: 4194 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110913/9b9812ee/attachment.bin>