[Freeipa-devel] [PATCH] 014 Code cleanup: widget creation
Endi Sukma Dewata
edewata at redhat.com
Tue Sep 13 17:43:56 UTC 2011
On 9/13/2011 7:57 AM, Petr Vobornik wrote:
> https://fedorahosted.org/freeipa/ticket/1788
>
> Removed code duplication of undo links.
> Simplified code of widget creation to be more readable.
ACK and pushed to master and ipa-2-1.
One little thing though, the create_undo() will always append a space
before the undo element. Right now it's not a problem, but suppose
there's a custom widget that doesn't want a space before the undo
element we can't use the standard method. We'll deal with that if it
becomes a problem.
--
Endi S. Dewata
More information about the Freeipa-devel
mailing list