[Freeipa-devel] [PATCH] 44 Fix parameter validation

[Jan Cholasta]

On 25.8.2011 18:21, Jan Cholasta wrote:
> What this patch does:
>
> * Make sure arguments are validated and default values are filled in
> before calling a command.
> * Add new parameter flag "validate_search" to force validation on search
> arguments.
> * Fix validation of IP network parameters in the DNS plugin.
>
> https://fedorahosted.org/freeipa/ticket/1627
>
> Honza
>

Redone the patch and split it to 3 parts:

   * [PATCH 46] Add IP address and IP network parameter types
     Adds two new parameter types, IPAddress and IPNetwork (which 
replaces the validate_search flag, as it was just a hack).

   * [PATCH 44] Fix parameter validation
     Changes Command.get_default so that default_from parameters are 
validated before they are used to create the default value.

   * [PATCH 47] Remove create_default
     Removes create_default, as it does exactly the same thing as 
default_from, but without the advantage of knowing what parameters are 
used to create the default value. All uses of create_default are 
replaced by default_from with no arguments, because that's all 
create_default is currently used for in IPA.

'make test' shows no regressions.

Honza

-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-46-parameter-ip.patch
Type: text/x-patch
Size: 53976 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110916/c51c46f1/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-44.2-parameter-validation.patch
Type: text/x-patch
Size: 6842 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110916/c51c46f1/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-47-parameter-remove-create-default.patch
Type: text/x-patch
Size: 17635 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110916/c51c46f1/attachment-0002.bin>