[Freeipa-devel] [PATCH] 271 Modified dialog to use sections.

[Petr Vobornik]

On 09/21/2011 10:10 PM, Endi Sukma Dewata wrote:
 > On 9/21/2011 6:50 AM, Petr Vobornik wrote:
 >
 > Fixed. The dialog fields don't need undo, so the text() needs to be
 > overridden to disable undo. This can be improved again later.
The override isn't necessary because it wasn't there before and all (at 
least I hope) fields in add dialogs specify undo: false. This feature 
can save some time though. Problem of current implementation is that it 
overrides only the default created section, not the sections specified 
in spec object. But as you wrote - this can be improved later.

 >
 >> 4) host.js:208,217: we should avoid using purely visual inline css
 >> styles. They should be replaced by class (if cannot be achieved by other
 >> selector) and styled in css file. This doesn't concern functional styles
 >> (animations, resizing, hiding, showing).
 >
 > Fixed. Yes, we should have a ticket to remove all inline CSS styles.

Are you sure the 'name' attribute is the right way to go? Wouldn't be 
'class' or 'id' (in this case) better? For table data 'name' attribute 
isn't even in HTML spec 
http://dev.w3.org/html5/spec/Overview.html#the-td-element.


-- 
Petr Vobornik