[Freeipa-devel] [PATCH] 271 Modified dialog to use sections.

[Endi Sukma Dewata]

On 9/22/2011 5:23 AM, Petr Vobornik wrote:
>  > Fixed. The dialog fields don't need undo, so the text() needs to be
>  > overridden to disable undo. This can be improved again later.

> The override isn't necessary because it wasn't there before and all (at
> least I hope) fields in add dialogs specify undo: false. This feature
> can save some time though. Problem of current implementation is that it
> overrides only the default created section, not the sections specified
> in spec object. But as you wrote - this can be improved later.

As discussed over IRC, instead of overriding the text() we will use 
section.undo to override the field.undo. This should set the undo 
properly in all sections in both dialog or details facet.

I've split the patch into two: 4a is the revised original patch, 4b is 
the additional cleanup for the undo.

>  >> 4) host.js:208,217: we should avoid using purely visual inline css
>  >> styles. They should be replaced by class (if cannot be achieved by
> other
>  >> selector) and styled in css file. This doesn't concern functional
> styles
>  >> (animations, resizing, hiding, showing).
>  >
>  > Fixed. Yes, we should have a ticket to remove all inline CSS styles.
>
> Are you sure the 'name' attribute is the right way to go? Wouldn't be
> 'class' or 'id' (in this case) better? For table data 'name' attribute
> isn't even in HTML spec
> http://dev.w3.org/html5/spec/Overview.html#the-td-element.

As discussed, the 'id' is global so the possibility of conflict is high. 
The 'name' is local so there is a little chance of conflict.

The 'class' is actually global but it can be qualified, which in this 
case ".host-adder-dialog table.fqdn". But there is still a risk that 
someone (e.g. the admin who wants to customize the CSS) might 
inadvertently define a global .fqdn that will affect all .fqdn elements 
including table.fqdn.

I've revised the patch to use 'class' for now. If this turns out to be a 
problem we'll figure out a different solution later.

-- 
Endi S. Dewata
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-edewata-0271-4a-Modified-dialog-to-use-sections.patch
Type: text/x-patch
Size: 50789 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110922/952be1f7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-edewata-0271-4b-Removed-undo-flags-from-dialog-field-specs.patch
Type: text/x-patch
Size: 17814 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110922/952be1f7/attachment-0001.bin>