[Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message

[Petr Vobornik]

On 09/15/2011 01:51 AM, Endi Sukma Dewata wrote:
> On 9/14/2011 7:23 AM, Petr Vobornik wrote:
>> Forgot to update tests - to address newly added validation row in
>> table_widget.
>
> One issue, in all search and association facets we now have 2 rows of
> footer (there are 2 horizontal lines at the bottom). I think it would be
> better to use a single row for both summary/error messages and
> pagination. The messages will be left aligned, the pagination will be
> right aligned.
>
It seems that the bigger problem is that these two lines of footer are 
displayed in search facet and association adder dialog. Anyway I've 
moved the error message to the same row as summary and pagination.

I've left summary on the left so error message will be displayed between 
the summary and the pager. To be more readable a margin-right was added 
to the summary so when the summary is empty error_message is on the 
left. Line-height is set for the footer so summary, error message and 
pagination are equally vertically aligned.

I've added padding and unified font-weight in error-message style. The 
padding is added because text of the message was right on the border 
which wasn't much readable. Font-weight is added because sometimes it 
inherits font-weight from other style and so it is inconsistent with 
other appearances. I'm not sure about the 'bold', though.

-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0016-2-Fixed-Some-widgets-do-not-have-space-for-validation-.patch
Type: text/x-patch
Size: 9630 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110927/570048a8/attachment.bin>