[Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message
Endi Sukma Dewata
edewata at redhat.com
Tue Sep 27 20:54:48 UTC 2011
On 9/27/2011 7:50 AM, Petr Vobornik wrote:
> I've added padding and unified font-weight in error-message style. The
> padding is added because text of the message was right on the border
> which wasn't much readable. Font-weight is added because sometimes it
> inherits font-weight from other style and so it is inconsistent with
> other appearances. I'm not sure about the 'bold', though.
This is good but can we use a new CSS class for the error message? I'd
rather not change the jquery-ui.css (removing white spaces is ok)
because it will be difficult to keep track the changes if we need to
upgrade it.
There's another minor issue, but this one can be fixed separately if you
want. Try editing a self-service permission, uncheck all attributes,
then click Update. The undo link and the error message appear in 2
separate lines. I think it's better to show them in a single line. When
we fix the attributes widget to inherit from table, they will fit into
the footer. The padding should be consistent as well, right now the undo
box is smaller than the error message.
--
Endi S. Dewata
More information about the Freeipa-devel
mailing list