[Freeipa-devel] [PATCH] 1005 fix password history

[Martin Kosek]

On Mon, 2012-04-09 at 23:54 -0400, Rob Crittenden wrote:
> Password history wasn't working because the qsort comparison function 
> was comparing pointers, not data. This resulted in a random element 
> being removed from the history on overflow rather than the oldest.
> 
> We sort in reverse so we don't have to move elements inside the list 
> when removing to make more room. We just pop off the top then shove on 
> the new password. The history includes a time to make comparisons 
> straightforward (and LDAP doesn't guarantee order).
> 
> I've attached a test script to exercise things. I don't see a way to 
> easily include this into our current framework at the moment. We'd need 
> a way to switch users in the middle of a test.
> 
> rob

Thanks. The new line looks quite scary, but it is OK and works fine
(explanation in "man qsort").

ACK. Pushed to master, ipa-2-2.

Martin