[Freeipa-devel] [PATCH] 0069 Add internationalization to DCE RPC code
Martin Kosek
mkosek at redhat.com
Tue Aug 14 14:54:09 UTC 2012
On 08/14/2012 04:34 PM, Alexander Bokovoy wrote:
> On Tue, 14 Aug 2012, Martin Kosek wrote:
>> On 08/14/2012 10:58 AM, Alexander Bokovoy wrote:
>>> Hi,
>>>
>>> fairly simple patch to wrap error messages to look up in translation
>>> catalog.
>>>
>>> https://fedorahosted.org/freeipa/ticket/2964
>>>
>>
>> Looks and works OK. I just don't think its necessary to translate our error
>> logging:
>>
>> - root_logger.error("LDAP error when connecting to %s: %s" %
>> (unicode(result.pdc_name), str(e)))
>> + root_logger.error(
>> + _("LDAP error when connecting to %(host)s: %(error)s") %
>> + dict(host=unicode(result.pdc_name), error=str(e)))
>>
>> Martin
>
> Yep. I've attached updated patch that still changes this place to use
> named arguments but drops _().
>
ACK. Pushed to master.
Martin
More information about the Freeipa-devel
mailing list