[Freeipa-devel] [PATCH] 207 Improve dnszone-add error message

[Rob Crittenden]

Martin Kosek wrote:
> When a new DNS record is being added to DNS zone via command
>    ipa dnsrecord-add ZONE @
> and the target ZONE does not exist it returns ObjectclassViolation
> which may confuse users. Make sure that standard DNS Zone NotFound
> exception is returned.
>
> https://fedorahosted.org/freeipa/ticket/2270

nack, I show two test failures with this patch.

======================================================================
FAIL: test_dns[29]: dnsrecord_add: Add MX record to zone u'dnszone.test' 
using dnsrecord_add
----------------------------------------------------------------------
Traceback (most recent call last):
   File "/usr/lib/python2.7/site-packages/nose/case.py", line 187, in 
runTest
     self.test(*self.arg)
   File 
"/home/rcrit/redhat/freeipa-review/tests/test_xmlrpc/xmlrpc_test.py", 
line 220, in <lambda>
     func = lambda: self.check(nice, test)
   File 
"/home/rcrit/redhat/freeipa-review/tests/test_xmlrpc/xmlrpc_test.py", 
line 236, in check
     self.check_output(nice, cmd, args, options, expected)
   File 
"/home/rcrit/redhat/freeipa-review/tests/test_xmlrpc/xmlrpc_test.py", 
line 264, in check_output
     assert_deepequal(expected, got, nice)
   File "/home/rcrit/redhat/freeipa-review/tests/util.py", line 320, in 
assert_deepequal
     assert_deepequal(e_sub, g_sub, doc, stack + (key,))
   File "/home/rcrit/redhat/freeipa-review/tests/util.py", line 314, in 
assert_deepequal
     doc, sorted(missing), sorted(extra), expected, got, stack
AssertionError: assert_deepequal: dict keys mismatch.
   test_dns[29]: dnsrecord_add: Add MX record to zone u'dnszone.test' 
using dnsrecord_add
   missing keys = ['nsrecord']
   extra keys = []
   expected = {'objectclass': [u'top', u'idnsrecord', u'idnszone'], 
'dn': u'idnsname=dnszone.test,cn=dns,dc=greyoak,dc=com', 'mxrecord': 
[u'0 ns1.dnszone.test.'], 'nsrecord': [u'ns1.dnszone.test.'], 
'idnsname': [u'dnszone.test']}
   got = {'objectclass': (u'top', u'idnsrecord'), 'dn': 
u'idnsname=@,idnsname=dnszone.test,cn=dns,dc=greyoak,dc=com', 
'mxrecord': (u'0 ns1.dnszone.test.',), 'idnsname': (u'@',)}
   path = ('result',)

======================================================================
FAIL: test_dns[33]: dnsrecord_add: Add LOC record to zone 
u'dnszone.test' using dnsrecord_add
----------------------------------------------------------------------
Traceback (most recent call last):
   File "/usr/lib/python2.7/site-packages/nose/case.py", line 187, in 
runTest
     self.test(*self.arg)
   File 
"/home/rcrit/redhat/freeipa-review/tests/test_xmlrpc/xmlrpc_test.py", 
line 220, in <lambda>
     func = lambda: self.check(nice, test)
   File 
"/home/rcrit/redhat/freeipa-review/tests/test_xmlrpc/xmlrpc_test.py", 
line 236, in check
     self.check_output(nice, cmd, args, options, expected)
   File 
"/home/rcrit/redhat/freeipa-review/tests/test_xmlrpc/xmlrpc_test.py", 
line 264, in check_output
     assert_deepequal(expected, got, nice)
   File "/home/rcrit/redhat/freeipa-review/tests/util.py", line 320, in 
assert_deepequal
     assert_deepequal(e_sub, g_sub, doc, stack + (key,))
   File "/home/rcrit/redhat/freeipa-review/tests/util.py", line 314, in 
assert_deepequal
     doc, sorted(missing), sorted(extra), expected, got, stack
AssertionError: assert_deepequal: dict keys mismatch.
   test_dns[33]: dnsrecord_add: Add LOC record to zone u'dnszone.test' 
using dnsrecord_add
   missing keys = ['nsrecord']
   extra keys = []
   expected = {'dn': u'idnsname=dnszone.test,cn=dns,dc=greyoak,dc=com', 
'nsrecord': [u'ns1.dnszone.test.'], 'objectclass': [u'top', 
u'idnsrecord', u'idnszone'], 'locrecord': [u'49 11 42.400 N 16 36 29.600 
E 227.64'], 'mxrecord': [u'0 ns1.dnszone.test.'], 'idnsname': 
[u'dnszone.test']}
   got = {'locrecord': (u'49 11 42.400 N 16 36 29.600 E 227.64',), 
'objectclass': (u'top', u'idnsrecord'), 'dn': 
u'idnsname=@,idnsname=dnszone.test,cn=dns,dc=greyoak,dc=com', 
'mxrecord': (u'0 ns1.dnszone.test.',), 'idnsname': (u'@',)}
   path = ('result',)