[Freeipa-devel] [PATCH] 210-213 Fix DNS record param issues

[Martin Kosek]

On Fri, 2012-02-03 at 17:19 +0200, Alexander Bokovoy wrote:
> On Fri, 03 Feb 2012, Martin Kosek wrote:
> > Endi found several issues with the new per-type DNS API. This set of
> > patches fixes them all. Testing should be quite straightforward, all
> > linked tickets contain failing scenarios.
> > 
> > Martin
> 
> > >From 9a4d5f97866cd9c28d5040a88c3e6626a073417c Mon Sep 17 00:00:00 2001
> > From: Martin Kosek <mkosek at redhat.com>
> > Date: Fri, 3 Feb 2012 10:01:27 +0100
> > Subject: [PATCH 1/4] Fix TXT record parsing
> > 
> > TXT record validation fails to parse the record if it contains
> > spaces. Standard DNS part parser uses a space to divide record
> > parts. A special parser thus need to be implemented for this RR
> > type.
> > 
> > https://fedorahosted.org/freeipa/ticket/2306
> ACK.
> 
> 
> > >From bd417d9c2ee5355d2ac1a40a09ad1d1b5630eba5 Mon Sep 17 00:00:00 2001
> > From: Martin Kosek <mkosek at redhat.com>
> > Date: Fri, 3 Feb 2012 10:41:21 +0100
> > Subject: [PATCH 2/4] Fix NSEC record conversion
> > 
> > NSEC record needs special treatment as it is not composed from
> > a fixed set of DNS parts divided by space, but it contains
> > a multivalued DNS part "types" containing a list of RR types
> > it covers.
> > 
> > There was already a special method for parsing raw NSEC record
> > to DNS parts, but the other direction was missing. This patch
> > adds special NSEC convertor to fix this issue.
> > 
> > https://fedorahosted.org/freeipa/ticket/2307
> ACK
> 
> > >From 9b6e99aad423cba821618fd7da1d37672649a24f Mon Sep 17 00:00:00 2001
> > From: Martin Kosek <mkosek at redhat.com>
> > Date: Fri, 3 Feb 2012 14:25:53 +0100
> > Subject: [PATCH 3/4] Add SRV record target validator
> > 
> > Add missing SRV record target validator to filter out possible
> > user errors.
> > 
> > https://fedorahosted.org/freeipa/ticket/2308
> ACK
> 
> > >From 7cadf3a0e739372f86184bf93c636f5b4e99a9cc Mon Sep 17 00:00:00 2001
> > From: Martin Kosek <mkosek at redhat.com>
> > Date: Fri, 3 Feb 2012 14:52:34 +0100
> > Subject: [PATCH 4/4] Add data field for A6 record
> > 
> > Since A6 is an obsolete RR type, no DNS part option was created.
> > This is, however, not consistent with the rest of per-type API
> > and may cause problems. This patch adds at least a DNS part for
> > raw A6 record data so that the record type is treated consistently.
> > 
> > https://fedorahosted.org/freeipa/ticket/2309
> ACK
> 

Pushed all to master, ipa-2-2.

Martin