[Freeipa-devel] [PATCH 59] Modify spec file to add ipa_memcached service Install &, control ipa_memcached instance

[John Dennis]

On 02/06/2012 10:26 AM, Rob Crittenden wrote:
> John Dennis wrote:
>> On 01/25/2012 09:12 AM, Rob Crittenden wrote:
>>> John Dennis wrote:
>>>> This patch supersedes the previous patch, it corrects two issue Rob
>>>> raised in a later patch review
>>>>
>>>> The fixed issues are:
>>>>
>>>> * spec file did not install ipa_memcached SysV initscript on SvsV
>>>> systems.
>>>>
>>>> * Typo in the name of the pid file variable in the ipa_memcached
>>>> initscript
>>>>
>>>
>>> NACK, two small things.
>>>
>>> ipa-server-install man page needs to be updated with new option.
>>>
>>> ipa_memcached is not chkconfig'd on/off when it is installed/uninstalled.
>>>
>>> Also, can you update the commit message, it isn't as descriptive as it
>>> usually is :-)
>>
>> Attached is a modified patch:
>>
>> Removed the ipa_memcached install option because it's mandatory for
>> proper operation now. This means there is no need to update the man page.
>>
>> See previous email concerning the chkconfig behavior. Please review the
>> earlier reply. If necessary I'll update the patch if you could be more
>> specific about your concerns but as it stands now I don't see a problem
>> with it.
>>
>> I added a much more descriptive commit message.
>
> IIRC I rebooted my box to be sure things came up properly and
> ipa_memcached did not start at boot. I chalked it up to chkconfig out of
> habit, but yeah, this was on F15 so systemd should have handled it.

It won't start if SELinux is in enforcing mode (at least not until we 
get a policy update).



-- 
John Dennis <jdennis at redhat.com>

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/