[Freeipa-devel] [PATCH] 074 Automember UI - default groups

[Petr Vobornik]

On 02/07/2012 07:51 AM, Endi Sukma Dewata wrote:
> On 2/6/2012 9:56 AM, Petr Vobornik wrote:
>> Updated patch attached.
>
> ACK and pushed to master and ipa-2-2. See the comments below.
>
>
> There's one minor issue. Try reloading the page when you don't have a
> default group, then click the drop down list, the list is empty, you'd
> have to click the search icon to populate it.

I noticed this issue. I'm fine with it. Yes it is little inconsistent. 
But: I don't like the default behavior of entity_select - fetching the 
entries on widget update. Most of the time it needs only show the value 
and the list is not used. If we had a page where would be a lot of 
entity_selects - it would executed a lot of useless commands. IMO it 
should fetch data when users opens the combobox or start typing in it.

>
>>> 3. The position of the default user/host group interface seems to be
>>> inconsistent with the rest of the UI. The behavior is also different,
>>> when you change the value it updates the server immediately without
>>> clicking any Update button. In my opinion it would be better to move it
>>> into a separate facet. So when you open the User Group Rules you'll see
>>> two tabs, one for the Rules (default), and the other for Settings. The
>>> Settings will have a field with a drop down list for the default user
>>> group. Any changes will have to be saved by clicking the Update button.
>>
>> I agree on the part that it is inconsistent with the rest of the UI and
>> user is not properly informed that the changes are immediately executed.
>>
>> Nevertheless I wouldn't move it to other facet. It seems to me as too
>> much clicking if you want to just check the default group.
>>
>> I can imagine this improvement: if a command is successfully executed it
>> would show on the right of the combobox a message saying: "default group
>> set" or "default group removed". The message can have style as the
>> message used in adder dialog (after "add and add another"). The message
>> would fade out after couple (5?) seconds.
>
> It will work but still kind of inconsistent because there's no Update
> button to confirm your selection.

Or we can just put an update button next to combobox which would be 
enabled when the value will change. Maybe also enable undo (and simulate 
field) for combobox.
>
> Another possibility, we can change the page to look like a details page.
> So it will have 2 sections: Default Group and Rules. The Default Group
> section will have one field: User Group with a drop down list. It also
> will have an Update button for this section only. The Rules section will
> have a search table with the Delete & Add buttons and the search field.
>

A possibility, the drawback is that it takes much more space -> less 
space for search part.


-- 
Petr Vobornik