[Freeipa-devel] [PATCH] 940 apply some validation to some classes only

[Rob Crittenden]

Rob Crittenden wrote:
> The variable name rdnattr can be misleading. It is only used to give the
> name of hte RDN in something that can be renamed. Compare this to
> something like netgroups where the DN has no visible relationship to the
> content of the object (ipaUniqueId). Only those objects that define
> rdnattr get a rename option (look at netgroups, for example).
>
> rdnattr is always the primary key but not always defined. It should
> probably be a boolean instead, rdn_is_primary_key or something a bit
> more obvious. I can make that change here.
>
> rob

Updated patch. It seems I broke query a few months ago trying to enforce 
no white spaces in some names.

I did the rdnattr variable rename. Looking back at the changelog this 
was meant to always match the primary key so lets remove the possibility 
that it doesn't. By doing it this way we get the pattern for free.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rcrit-940-4-validation.patch
Type: text/x-diff
Size: 14370 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120220/af181411/attachment.bin>