[Freeipa-devel] [PATCH] 0015 Only split CSV strings once

[Petr Viktorin]

On 02/24/2012 11:09 AM, Petr Viktorin wrote:
> On 02/23/2012 04:08 PM, Jan Cholasta wrote:
>  > Can't you just re-escape the values before forwarding the call? That
>  > would be a fairly straightforward fix and it would remove the need for
>  > all the _forwarded_call hackery.
>
> All right, I'll do that once we decide on how to escape. Self-NACK for
> the patch.
>
> ...

I hit Send too early. Re-escaping the values would be a bad thing to do, 
because it would mean the server would still need to unescape. If I did 
that, we couldn't fix the problem properly later.

The proper fix is to do CSV splitting only at the client. Just like it 
converts "" to None or multiple options to lists, it should convert CSV 
to lists. There's no need for the backend to worry itself over a 
CLI-specific encoding.


-- 
Petr³