[Freeipa-devel] [PATCH] 966 limit allowed characters in netgroup name

[Rob Crittenden]

Martin Kosek wrote:
> On Fri, 2012-02-24 at 15:01 -0500, Rob Crittenden wrote:
>> Limit the characters in a netgroup name to alpha, digits, -, _ and .
>>
>> rob
>
> NACK.
>
> 1) The regular expressions is not correct, you forget the ending "$".
> Thus it matches any string with the right beginning. Like this one:
>
> # ipa netgroup-add "foo+bar" --desc=baz
> ipa: ERROR: Can't contact LDAP server:
>
> 2) Shouldn't we add a similar validator for hostgroups too? Netgroups
> are created out of hostgroups, i.e. I think they should share name
> restrictions.
>
> Martin
>

Nice catch. Fixed both and added simple test cases.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rcrit-966-2-netgroup.patch
Type: text/x-diff
Size: 9873 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120227/18013937/attachment.bin>