[Freeipa-devel] [PATCH] 14 ipa permission-add does not fail if using invalid attribute

[Ondrej Hamada]

On 02/27/2012 03:22 PM, Rob Crittenden wrote:
> Ondrej Hamada wrote:
>> When adding or modifying permission with both type and attributes
>> specified, check whether the attributes are allowed for specified type.
>> In case of disallowed attributes the InvalidSyntax error is raised.
>>
>> New tests were also added to the unit-tests.
>>
>> https://fedorahosted.org/freeipa/ticket/2293
>>
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>
> NACK. You should use obj.object_class_config to determine if the 
> default list of objectclasses comes from LDAP.
>
> I think that may be it, otherwise the patch reads ok.
>
> I'm very glad to see unit tests!
>
> rob
Corrected

-- 
Regards,

Ondrej Hamada
FreeIPA team
jabber: ohama at jabbim.cz
IRC: ohamada

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-ohamada-14-2-Validate-attributes-in-permission-add.patch
Type: text/x-patch
Size: 6305 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120227/b1b376cc/attachment.bin>