[Freeipa-devel] [PATCH] 0008 - Make sure the nolog argument to ipautil.run is not a bare string

[Rob Crittenden]

Petr Viktorin wrote:
> `ipautil.run` expects a tuple for its `nolog` argument, but works with
> any other iterable (sometimes we use lists as well). Since strings are
> also iterable, and yield their characters, this caused every individual
> character in the password to be replaced, leading to log messages like:
>
> ---
> You will be prompXXXXXXXXed for XXXXXXXXhe daXXXXXXXXabase MasXXXXXXXXer
> Password.
> XXXXXXXXXXXXXXXX is imporXXXXXXXXaXXXXXXXXXXXXXXXX XXXXXXXXhaXXXXXXXX
> you NOT FOXXXXXXXXGET XXXXXXXXhis password.
> ---
>
>
>
> The attached patch modifies ipautil.run to ensure nolog is not a bare
> string. It also fixes a call in ipaserver/install/krbinstance.py.

ACK, pushed to master and ipa-2-2

rob