[Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

Rob Crittenden rcritten at redhat.com
Mon Feb 27 22:03:35 UTC 2012


Petr Viktorin wrote:
> Patch 16 defers validation & conversion until after {add,del,set}attr is
> processed, so that we don't search for an integer in a list of strings
> (this caused ticket #2405), and so that the end result of these
> operations is validated (#2407).
>
>
> Patch 17 makes these options honor params marked no_create and no_update.
>
>
> https://fedorahosted.org/freeipa/ticket/2405
> https://fedorahosted.org/freeipa/ticket/2407
> https://fedorahosted.org/freeipa/ticket/2408

NACK on Patch 17 which breaks patch 16.

*attr is specifically made to be powerful. We don't want to arbitrarily 
block updating certain values.

Not having patch 17 means that the problem reported in 2408 still 
occurs. It should probably check both the schema and the param to 
determine if something can have multiple values and reject that way.

rob




More information about the Freeipa-devel mailing list