[Freeipa-devel] [PATCH] 080-085 DNS UI update

[Petr Vobornik]

On 02/24/2012 11:00 PM, Endi Sukma Dewata wrote:
> ACK. Feel free to push once the required server piece is ready.

Patches 80,81,82-1,83,84,85,90,91,92,93 pushed to master and ipa-2-2

>
> On 2/23/2012 7:06 AM, Petr Vobornik wrote:
>>> 3. When adding an A/AAAA record and checking the 'create reverse'
>>> option, if the reverse zone doesn't exist it will show an error dialog
>>> box saying it cannot create the reverse record. The A/AAAA record is
>>> actually created but the page is not refreshed. I think it should detect
>>> the error 4304 and refresh the page.
>>>
>> Fixed: I generalized and reused the code in host adder dialog. I'm
>> wondering if it would be better to put it in command code so it would be
>> default handler for this error type. It's done in separate patch: 92.
>
> Yeah, there probably should be a way to define the default handlers for
> various error codes which can still be overridden for a specific
> situation. Maybe we can register the default handlers in an
> error_handlers map in the IPA object?

Sounds good.

>
>>> 8. The behavior of the checkboxes for idnsforwardpolicy is a bit unusual
>>> because you can only select at most one value. Usually checkboxes allow
>>> you to select multiple values. It might be better to use 3 radio buttons
>>> for all possible values: only, first, and none/default.
>>
>> It is unusual. I think the 'none/default' can be a bit unusual/confusing
>> too. It may not be clear that the value will be '', user can expect that
>> the value will be set to 'none' or actual default - if the attribute has
>> some. What about radios an 'unset' link below them?
>
> We probably can use a more descriptive label such as 'Forward only'
> instead of just 'only', but the idea is we provide 3 radio buttons for
> the 3 possible options. The general understanding is that with radio
> buttons the field have exactly 1 value whereas with checkboxes there
> could be 0-n values. Right now we have 2 checkboxes but we can only
> select 0 or 1 value, that's why it's a bit unusual. Adding an unset link
> is possible too, but it won't be as intuitive as selecting one of the
> radio buttons.
>
You are probably right. I'll mark it for myself as possible improvement. 
(after a release I'll probably go through all these marked mails and 
make some tickets).


-- 
Petr Vobornik