[Freeipa-devel] [PATCH] 217-220 minor DNS fixes and improved validation

[Rob Crittenden]

Martin Kosek wrote:
> On Mon, 2012-02-27 at 15:15 -0500, Rob Crittenden wrote:
>> Martin Kosek wrote:
>>> On Tue, 2012-02-21 at 17:27 +0100, Martin Kosek wrote:
>>>> This set of 3 DNS patches fixes 2 minor issues found during DNS test day
>>>> (217, 218) and there is slightly longer patch (219) which improves and
>>>> consolidates hostname/domain name validation.
>>>>
>>>> The testing should be pretty straightforward in case of these 3 tickets.
>>>>
>>>> Martin
>>>
>>> I forgot to generate API.txt in patch 219. Fixed version is included.
>>>
>>> While at it I made another patch (220) to DNS/host plugins built on
>>> 217-219. It fixes the way we handle FQDNs with ending "." in both
>>> plugins. It will also fix bug that Marco Pizzoli was experiencing.
>>>
>>> Some clean ups in host plugin procedures for finding DNS zone for a host
>>> were needed so that host's IP address is added correctly to DNS zones
>>> with trailing dot.
>>>
>>> Martin
>>
>> A bit of rebasing is required on most of these.
>
> Thanks. I rebased all of those and fixed reported errors and also a
> misformatted except clause.
>
>> 217 ACK
>
> Pushed to master, ipa-2-2.
>
>>
>> 218. NACK. The invalid values are still accepted and you get the same
>> error message "No options to add...". This is different than entering an
>> invalid type like XYZ. I think we should instead either not allow entry
>> at all or recognize that it is unsupported and say so.
>
> Good catch. I just fixed the error message, not the actual check. Fixed.
>
>>
>> 219. NACK. The error message doesn't include _ in the list of allowed
>> characters but it accepts it (it probably shouldn't). IPA hostnames do not.
>
> Error message fixed. _ need to be allowed for DNS record names, they are
> used for example for SRV records. They are just not allowed for
> hostnames.
>
>>
>> 220 NACK. The ticket number is wrong and the patch doesn't apply.
>>
>> rob
>
> Fixed.

ACK 218, 219, 220

rob