[Freeipa-devel] [PATCH] 975 don't delete system users we add

Martin Kosek mkosek at redhat.com
Wed Feb 29 21:38:13 UTC 2012


On Wed, 2012-02-29 at 15:51 -0500, Rob Crittenden wrote:
> Rob Crittenden wrote:
> > Martin Kosek wrote:
> >> On Tue, 2012-02-28 at 23:07 -0500, Rob Crittenden wrote:
> >>> Don't call userdel during uninstall to delete any system users we
> >>> create. If they are deleted and the system adds another user for some
> >>> reason (package install, for example) then file ownership can get hosed.
> >>>
> >>> rob
> >>
> >> NACK
> >>
> >> There is still a groupdel for dirsrv group. This makes the whole
> >> uninstall to blow up:
> >
> > Ouch, nice catch. It didn't blow up for me and I totally missed this.
> >
> > Updated patch.
> >
> > rob
> 
> Martin noticed that we were still saving the user/group existence state. 
> We don't need to do that.
> 
> I left in the restoring state so upgrades still have this removed on 
> uninstall.
> 
> rob

Yeah, its OK now, thanks.

ACK. Pushed to master, ipa-2-2.

Martin




More information about the Freeipa-devel mailing list