[Freeipa-devel] [PATCH] 0070 Fix updating minimum_connections in ipa-upgradeconfig

[Petr Viktorin]

On 07/19/2012 03:04 PM, Rob Crittenden wrote:
> Petr Viktorin wrote:
>> On 07/18/2012 09:45 PM, Rob Crittenden wrote:
>>> Petr Viktorin wrote:
>>>> minimum_connections was sometimes not updated properly on install
>>>> because the script set psearch on but assumed it was still off.
>>>> Also, the number of connections was not set if the directive was
>>>> missing.
>>>>
>>>> Fix of the patch for https://fedorahosted.org/freeipa/ticket/2554
>>>
>>> Your changes look good but I found perhaps another bug. I think Petr
>>> Spacek may need to chime in on this part.
>>>
>>> If you start out with serial_autoincrement yes and psearch undefined and
>>> connections undefined the result is:
>>>
>>> connections 2
>>>
>>> There is a comment in the code that connections needs to be 4 for
>>> autoincrement. I believe psearch needs to be enabled for autoincrement.
>>> I'm not sure how much sanity checking we want to do, mostly I'm curious
>>> if things will blow up with connections 2 and no psearch and
>>> autoincrement.
>>>
>>> rob
>>
>> Petr Špaček tells me you'll get an error if serial_autoincrement is
>> enabled without psearch.
>> Do we want to fix things if users start out with broken configuration?
>>
>
> I think that if we can detect that a configuration is broken we should
> complain loudly, if not fix it (and still complain).
>
> rob
>

I made the warning into an error message, hopefully that counts as 
complaining loudly.

Anyway with Petr²'s patch 36 it doesn't really matter any more, since 
the plugin will fix the error (and still complain) for us :)

-- 
Petr³


-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0070-02-Fix-updating-minimum_connections-in-ipa-upgradeconfi.patch
Type: text/x-patch
Size: 3536 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120719/3d998f43/attachment.bin>