[Freeipa-devel] [PATCH] 956 user lockout status

Rob Crittenden rcritten at redhat.com
Thu Mar 1 21:26:04 UTC 2012


Martin Kosek wrote:
> On Wed, 2012-02-29 at 11:20 +0100, Petr Viktorin wrote:
>> On 02/27/2012 06:31 PM, Martin Kosek wrote:
>>>
>>> 4) Minor change:
>>> -                except Exception:
>>> +                except:
>>>
>>
>> Don't do that. It would for example disable Ctrl+C by trapping
>> KeyboardInterrupt.
>>
>> PEP8 has a paragraph on this, search for 'except Exception:'
>>
>>
>
> Good to know, thanks. Rob, in that case please ignore issue #4.
>
> Martin

Updated patch attached.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rcrit-956-2-status.patch
Type: text/x-diff
Size: 2199 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120301/76d273a8/attachment.bin>


More information about the Freeipa-devel mailing list