[Freeipa-devel] [PATCH] 0010 Remove unnecessary mctx double checks

Petr Spacek pspacek at redhat.com
Tue Mar 6 12:46:36 UTC 2012


Hello,

this patch removes unnecessary double checks for isc_mem, which are 
scattered through the code.

This problem was mentioned yesterday (another) patch review:
https://www.redhat.com/archives/freeipa-devel/2012-March/msg00073.html

On 03/05/2012 12:32 PM, Adam Tkac wrote:
 >> >  +	REQUIRE(mctx != NULL);
 > REQUIRE(mctx != NULL); is not needed, every isc_mem_* function checks 
mctx
 > validity.

I checked each REQUIRE(mctx != NULL) and reference to "mctx" and Adam is 
right :-D

-- 
Petr^2 Spacek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bind-dyndb-ldap-pspacek-0010-Remove-unnecessary-mctx-double-checks.patch
Type: text/x-patch
Size: 4941 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120306/4a51e765/attachment.bin>


More information about the Freeipa-devel mailing list