[Freeipa-devel] [PATCH] 102-103 UI part of 'Add last missing bits in new bind-dyndb-ldap'

[Endi Sukma Dewata]

ACK. There are some minor issues.

On 3/7/2012 10:10 AM, Petr Vobornik wrote:
> 1) Add support of new options in dnsconfig
>
> dnsconfig was extended of new attributes, so reflecting it in UI.
>
> New attributes:
> * idnsForwardPolicy
> * idnsAllowSyncPTR
> * idnsZoneRefresh
>
> https://fedorahosted.org/freeipa/ticket/2489

If you click the idnsallowsyncptr checkbox and click again to return to 
the original value, it will still show the undo button.

> 2) DNS forwarder's value can consist of IP address and a port.
>
> The syntax is '<IP ADDRESS> port <PORT>'. A new validator was created
> for this purpose. It is based on IP address validator.

The validator is rather strict, it allows exactly a single space between 
the words. If someone mistakenly type an additional space, the 
validation error could be confusing because two adjacent spaces are 
sometimes not very obvious. I think either the UI or the server (or 
both) should normalize the space. Another option is to use separate 
fields for the IP address and the port in the multivalued field:

Global forwarders: [192.168.1.1  ] port [80  ]  Delete
                    Add

-- 
Endi S. Dewata