[Freeipa-devel] [PATCH] 0027 Use valid argument names in tests

Petr Viktorin pviktori at redhat.com
Wed Mar 14 16:02:43 UTC 2012


This patch depends on my patch 0024 (but I can rebase if it needs to be 
pushed earlied).

It fixes some of the test bugs that would be found by a fix for 
https://fedorahosted.org/freeipa/ticket/2509 (Unknown Command arguments 
are allowed (and ignored)).

As you can see it's quite easy, without validation, to use a wrong name 
for an argument.

Unfortunately, some of our plugins (automount, dns, delegation, 
permission, selfservice) take advantage of the current sloppy 
validation, so they'll need some untangling for 3.x to make them more 
robust and testable. For now I'm just touching the tests, so we don't 
get new bugs in production code.

-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0027-Use-valid-argument-names-in-tests.patch
Type: text/x-patch
Size: 7294 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120314/2ef339b3/attachment.bin>


More information about the Freeipa-devel mailing list