[Freeipa-devel] [PATCHES] Improve framework parameter validation

[Jan Cholasta]

On 15.3.2012 11:36, Jan Cholasta wrote:
> (this is a continuation of
> <http://www.redhat.com/archives/freeipa-devel/2011-September/msg00327.html>)
>
>
> Hi,
>
> the attached patches fix <https://fedorahosted.org/freeipa/ticket/1847>
> and <https://fedorahosted.org/freeipa/ticket/2245>:
>
> [PATCH] Fix the procedure for getting default values of command parameters.
>
> The parameters used in default_from of other parameters are now properly
> validated before the default_from is called.
>
> [PATCH] Change parameters to use only default_from for dynamic default
> values.
>
> Replace all occurences of create_default with equivalent default_from
> and remove create_default from the framework. This is needed for proper
> parameter validation, as there is no way to tell which parameters to
> validate prior to calling create_default, because create_default does
> not provide information about which parameters are used for generating
> the default value.
>
> Honza
>

Forgot to remove one FIXME bit in dns.py. Update patch attached.

Honza

-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-44.4-parameter-validation.patch
Type: text/x-patch
Size: 10028 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120315/e80c0f9a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-47.4-parameter-remove-create-default.patch
Type: text/x-patch
Size: 13047 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120315/e80c0f9a/attachment-0001.bin>