[Freeipa-devel] [PATCH] 986 remove unnecessary serial conversions

[Petr Viktorin]

On 03/15/2012 06:31 PM, Rob Crittenden wrote:
> This is related to my patch 924. Petr Viktorin noticed a couple of
> serial to hex conversions were wrong and it turns out they aren't needed
> at all. This patch removes them.
>
> rob

On 03/15/2012 06:32 PM, Rob Crittenden wrote:
 > Petr Viktorin wrote:
 >>
 >> I think you should also update the docstrings with the new item.
 >>
 >
 > What docstrings are those?

The big tables, such as:
     +----------------+---------------+-----------------+---------------+
     |cms name        |cms type       |result name      |result type    |
     +================+===============+=================+===============+
     |emailCert       |Boolean        |email_cert       |bool           |
     +----------------+---------------+-----------------+---------------+
     |noCertImport    |Boolean        |no_cert_import   |bool           |
     +----------------+---------------+-----------------+---------------+
     |revocationReason|int            |revocation_reason|int [1]_       |
     +----------------+---------------+-----------------+---------------+
     |certPrettyPrint |string         |cert_pretty      |unicode        |
     +----------------+---------------+-----------------+---------------+
     |authorityid     |string         |authority        |unicode        |
     +----------------+---------------+-----------------+---------------+
     |certFingerprint |string         |fingerprint      |unicode        |
     +----------------+---------------+-----------------+---------------+
     |certChainBase64 |string         |certificate      |unicode [2]_   |
     +----------------+---------------+-----------------+---------------+
     |serialNumber    |string         |serial_number    |int|long       |
     +----------------+---------------+-----------------+---------------+
     |pkcs7ChainBase64|string         |pkcs7_chain      |unicode [2]_   |
     +----------------+---------------+-----------------+---------------+
etc.



-- 
Petr³