[Freeipa-devel] [PATCH] 0013 Fix SOA record update

[Petr Spacek]

On 03/23/2012 11:58 AM, Adam Tkac wrote:
> On 03/22/2012 04:27 PM, Petr Spacek wrote:
>> this patch fixes wrong SOA updates during DNS zone dynamic update (via
>> nsupdate).
>>
>> It fixes LDAP plugin part of BZ:
>> https://bugzilla.redhat.com/show_bug.cgi?id=805871
>
> Good catch, the patch looks fine for me, please check my comments and
> then push it.
>
> Regards, Adam

>>
>> Incorrect SOA serial number format after IPA installation has to be
>> solved in IPA install scripts.
>>
>> Petr^2 Spacek
>>
>> bind-dyndb-ldap-pspacek-0013-Fix-SOA-record-update.patch

>> +#define MAX_SOANUM_LENGTH 10
> What about defining this to 11? After that you can omit "+ 1" additions
> below.
(10 + 1) applied.

>> - change[index].mod_values[0] = alloca(sizeof(soa.name) + 1); \
>> + change[index].mod_values[0] = alloca((MAX_SOANUM_LENGTH +
>> 1)*sizeof(char)); \
> Although this is correct, I don't think that "*sizeof(char)" is needed,
> please remove it.
I'm probably too paranoid  :-)


Recommended changes applied, pushed to master.

https://fedorahosted.org/bind-dyndb-ldap/changeset/709e352e52141eac346139666483b5c5f5acd713

Petr^2 Spacek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bind-dyndb-ldap-pspacek-0013-Fix-SOA-record-update.patch
Type: text/x-patch
Size: 2033 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120323/6e46f8a1/attachment.bin>