[Freeipa-devel] [PATCH] 234 Avoid deleting DNS zone when a context is reused

[Petr Viktorin]

On 03/23/2012 10:33 AM, Martin Kosek wrote:
> On Thu, 2012-03-08 at 14:57 +0100, Martin Kosek wrote:
>> When dnsrecord-del pre_callback detects that the record does
>> not contain any records, it set a flag to connection context
>> and deletes the record object later. However, when more
>> dnsrecord-del share the same context (and this is the case of
>> "ipa-replica-manage del $MASTER" DNS cleanup), it may reuse
>> a positive flag from previous dnsrecord-del command and delete
>> the root DNS zone record and thus effectively delete the zone.
>>
>> This patch makes sure that this flag is always initialized to
>> sane value in dnsrecord-del pre_callback to make sure that the DNS
>> zone is not deleted. It also fixes pre_callback function definition
>> to prevent adding attrs_list to "keys" parameter and thus confuse
>> developers.
>>
>> https://fedorahosted.org/freeipa/ticket/2503
>
> Sending a rebased patch which applies to current ipa-2-2.
>
> Martin
>
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

This fixes the issue. ACK.
It would be nice to have a comment hinting at what the del_all flag 
does. The option with the same name makes it somewhat unclear.

-- 
Petr³