[Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

Rob Crittenden rcritten at redhat.com
Tue Mar 27 14:08:16 UTC 2012


Petr Viktorin wrote:
> On 03/26/2012 10:34 PM, John Dennis wrote:
>> On 03/26/2012 01:11 PM, Petr Viktorin wrote:
>>> Just a one-liner: The docstring of validate_anonymous_substitutions
>>> isn't up to par ­­– there's a missing quote, extra “a”, and the '%s
>>> occurred' has no context. I suggest:
>>>
>>> We do not permit multiple anonymous substitutions in translation
>>> strings (e.g. '%s') because they do not allow translators to reorder the
>>> wording. Instead keyword substitutions should be used when there are
>>> more than one.
>>>
>>>
>>> ACK if that's fixed
>>
>> Done, patch attached.
>>
>
> ACK
>

pushed to master and ipa-2-2




More information about the Freeipa-devel mailing list