[Freeipa-devel] [PATCH] 0032 Move DNS test skipping to class setup

[Petr Viktorin]

On 03/29/2012 10:18 PM, Rob Crittenden wrote:
> Petr Viktorin wrote:
>>
>> Currently, each DNS test case first checks if DNS is configured
>> by creating and deleting a test zone. This takes quite a lot of time.
>>
>> This patch moves the check to the setUpClass method, so the check is
>> only done once for all the tests.
>>
>>
>>
>> On my VM, this makes the DNS plugin tests 50% faster, saving about half
>> a minute for each test run.
>>
>
> This fails if the test XML-RPC server is not running. While working on
> that issue I found a few other places that weren't handling this as
> well. Here is my working patch on top of yours.
>
> rob

Thank you! I see the other place is one I added recently.

This updated patch includes your diff, and also makes sure a context is 
created for the DNS test skipping.


-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0032-02-Move-test-skipping-to-class-setup.patch
Type: text/x-patch
Size: 3203 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120330/a047ab98/attachment.bin>