[Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

[Petr Vobornik]

On 05/03/2012 03:19 PM, Petr Vobornik wrote:
> I found that limitation of maximum pkey length in facet header is not
> working well. Attaching patch #134 which actually calculates it.

I found useless line in the patch. Corrected version attached.

>
> On 05/02/2012 03:33 PM, Petr Vobornik wrote:
>> This bunch of patches are implementing ticket #2247. They introduce some
>> new logic and types of internal objects. There might be design issues
>> (mainly in state evaluation). I would appreciate some opinions on what
>> might be improved.
>>
>> See patch comments for more details.
>>
>> What I think might be the main concerns:
>>
>> Action list definition:
>> Now action lists are defined on facet level and facet header takes them
>> from facet. Would in be better to define action list - the widget and
>> actions separately. The widget could be defined in header and actions on
>> facet level.
>>
>> State evaluation:
>> The patches are adding support for some kind of state evaluation. The
>> state is represented by array of string. I'm thinking that the design
>> might not be robust. Is a string good enough? We might have a problem
>> with conditions like to "have this particular access right' (#2318).
>> There are state_evaluators and state_listeners. They are practically the
>> same but the execution point and parameters are different. Should they
>> be somehow joined?
>>
>> Code placement:
>> There's a lot of new objects and for some of them it is not clear to
>> what code file they should be placed.
>>
>> FYI: In close future I would like to address some problems in UI
>> architecture. I'm in a middle of designing phase, so there is nothing to
>> present at the moment. The main topics are:
>> * reduce the need of overriding methods when a new widgets or
>> capabilities are added
>> * make it more declarative to enhance extendibility
>> It may be done by:
>> * better inheriting model to support events
>> * build phases (preinit, init, postinit, create, load) to improve spec
>> object creating and initialization of created object.
>> * path representation of an event/attribute/model property to support
>> bindings to various events/attrs from anywhere
>> * introduce model and model bindings, converters between command
>> output/model/human readable representation
>>
>>
>>
>> _______________________________________________
>> Freeipa-devel mailing list
>> Freeipa-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>
>
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel


-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0134-1-Improved-calculation-of-max-pkey-length-in-facet-hea.patch
Type: text/x-patch
Size: 2145 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120503/0e7e78d1/attachment.bin>