[Freeipa-devel] [PATCH 0051-0052] Log successful reconnection to LDAP server

Adam Tkac atkac at redhat.com
Wed Sep 5 14:37:45 UTC 2012


On Wed, Sep 05, 2012 at 03:53:36PM +0200, Petr Spacek wrote:
> On 09/05/2012 01:29 PM, Adam Tkac wrote:
> >On Wed, Aug 15, 2012 at 01:20:08PM +0200, Petr Spacek wrote:
> >>Hello,
> >>
> >>this two patches solves upstream ticket
> >>https://fedorahosted.org/bind-dyndb-ldap/ticket/71
> >>"Log successful reconnect"
> >>
> >>Patch 51:
> >>     Adds log_info(): logging facility with log level INFO.
> >
> >Ack.
> >
> >>Patch 52:
> >>     Logs successful reconnection to LDAP server.
> >>
> >>     LDAP connection error handling was modified:
> >>     Errors are handled exclusively by handle_connection_error() now.
> >>
> >>     Direct calls to ldap_connect() and ldap_reconnect() should be avoided.
> >
> >Nack, please check my comments below.
> 
> Thanks for your comments! Corrected patches are attached + I replied in-line.

Ack

-- 
Adam Tkac, Red Hat, Inc.




More information about the Freeipa-devel mailing list