[Freeipa-devel] [PATCH] 204 Update of confirmation of actions

[Endi Sukma Dewata]

On 9/3/2012 11:05 AM, Petr Vobornik wrote:
> This patch is changing confirmation of actions according to ticket
> #3035, see the ticket description.
>
> It does following changes:
>   * Confirmation of update action was removed.
>   * Action lists resets to first action (which is usually a NOP: '--
> select action --') on change of displayed entry.
>   * New confirmation dialog was implemented. It is used for action
> confirmation. It is used in IPA.action to replace the call of
> window.confirm(message). The old call is a modal window which blocks all
> JS functionality and has different style than other dialogs in Web UI.
> The new one has same design and doesn't block background operations.
>
>   https://fedorahosted.org/freeipa/ticket/3035

Some issues:

1. None of the confirmation dialogs have a default button. If you hit 
Enter it will do nothing (except #2 below). All buttons are greyed out 
until you hover with mouse or focus with Tab. Is this intentional? I 
think usually a confirmation dialog would have a default button.

2. In the Users search facet the confirmation dialog doesn't show 
default button either, but if you hit Enter it will execute the 
operation. This is inconsistent with #1.

-- 
Endi S. Dewata