[Freeipa-devel] [PATCH] 206-208 Fixed number parameters MIN boundary validation in Web UI

Endi Sukma Dewata edewata at redhat.com
Wed Sep 5 21:40:12 UTC 2012


On 9/5/2012 9:08 AM, Petr Vobornik wrote:
> Integers were missing most of minimum checks and Decimals boundaries
> weren't checked at all in Web UI.
>
> First part is done in ipalib, second in Web UI.
>
> 1) [PATCH] 206 Fixed metadata serialization of Numbers and DNs:
> There were following problems:
> 1. DNs and Decimals weren't properly serialized. Serialization output
> was object with empty __base64__ attribute. It was fixed by converting
> them to string.
> 2. numberical values equal to 0 were excluded from metadata. It broke
> many of minvalue checks in Web UI. Now excluding only None and False
> values as initially intended.

ACK.

> 2)[PATCH] 207 Added decimal checks to metadata validator:
> Metadata validator didn't have check for decimal values. It was added.

ACK.

> 3)[PATCH] 208 Generated metadata for testing updated
> Testing metadata needs to be updated because of fix in json serialization.

ACK.

-- 
Endi S. Dewata




More information about the Freeipa-devel mailing list