[Freeipa-devel] [PATCH] 204 Update of confirmation of actions

[Petr Vobornik]

On 09/06/2012 11:24 AM, Petr Vobornik wrote:
> On 09/05/2012 09:30 PM, Endi Sukma Dewata wrote:
>> On 9/3/2012 11:05 AM, Petr Vobornik wrote:
>>> This patch is changing confirmation of actions according to ticket
>>> #3035, see the ticket description.
>>>
>>> It does following changes:
>>>   * Confirmation of update action was removed.
>>>   * Action lists resets to first action (which is usually a NOP: '--
>>> select action --') on change of displayed entry.
>>>   * New confirmation dialog was implemented. It is used for action
>>> confirmation. It is used in IPA.action to replace the call of
>>> window.confirm(message). The old call is a modal window which blocks all
>>> JS functionality and has different style than other dialogs in Web UI.
>>> The new one has same design and doesn't block background operations.
>>>
>>>   https://fedorahosted.org/freeipa/ticket/3035
>>
>> Some issues:
>>
>> 1. None of the confirmation dialogs have a default button. If you hit
>> Enter it will do nothing (except #2 below). All buttons are greyed out
>> until you hover with mouse or focus with Tab. Is this intentional? I
>> think usually a confirmation dialog would have a default button.
>>
>> 2. In the Users search facet the confirmation dialog doesn't show
>> default button either, but if you hit Enter it will execute the
>> operation. This is inconsistent with #1.
>>
>
> Root of the problem is that old custom dialogs which serves for
> confirmation (batch delete, various certificate and unprovisioning
> dialogs) or other dialogs (password change, adder dialogs) don't have
> confirmation by enter. Only the new dialog has confirmation by Enter. At
> the moment this new dialog is used only for mass enable/disable.
>
> We might:
> a) remove confirmation confirmation by pressing Enter key from the new
> dialog to be consistent. IMO wrong.
> b) add this confirmation too all dialogs
> c) change old confirm dialogs to inherit from IPA.confirm_dialog to
> receive this functionality
>
> IMO, for most dialogs c) would be better but for some (highly
> customized) b). It should be probably done in other patch, maybe it the
> context of this ticket.
>
> There is also: https://fedorahosted.org/freeipa/ticket/2910 ([Web UI]
> Use "Enter" to confirm add dialogs)
>

Pushed to master, ipa 3-0

I agreed with Endi over IRC that this patch will be pushed to make to RC1.

Ticket will remain opened and moved to RC2 where combination of (b) and 
(c) will be addressed.

-- 
Petr Vobornik