[Freeipa-devel] [PATCH 0069] Fix crash caused by empty zone renaming

[Adam Tkac]

On Mon, Sep 24, 2012 at 03:45:25PM +0200, Petr Spacek wrote:
> Hello,
> 
>     Fix crash caused by empty zone renaming.
> 
>     LDAP query uses LDAP_SCOPE_ONELEVEL scope so original condition
>     in INSIST is incorrect, because zone is not required to have child
>     names (i.e. names other than zone itself).

Ack

> From 6d59d4beacf5339aec260bac6bd3c69839efb1f7 Mon Sep 17 00:00:00 2001
> From: Petr Spacek <pspacek at redhat.com>
> Date: Mon, 24 Sep 2012 15:34:11 +0200
> Subject: [PATCH] Fix crash caused by empty zone renaming.
> 
> LDAP query uses LDAP_SCOPE_ONELEVEL scope so original condition
> in INSIST is incorrect, because zone is not required to have child
> names (i.e. names other than zone itself).
> 
> Signed-off-by: Petr Spacek <pspacek at redhat.com>
> ---
>  src/ldap_helper.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/ldap_helper.c b/src/ldap_helper.c
> index 373d57ac385d4db7394959c23c511e1734503989..33eab72f2b37a792a97a6c85f21a3501d399380c 100644
> --- a/src/ldap_helper.c
> +++ b/src/ldap_helper.c
> @@ -3093,8 +3093,6 @@ update_zone(isc_task_t *task, isc_event_t *event)
>  					LDAP_SCOPE_ONELEVEL, attrs_record, 0,
>  					"(objectClass=idnsRecord)"));
>  
> -			/* LDAP schema requires SOA record (at least) */
> -			INSIST(HEAD(ldap_qresult_record->ldap_entries) != NULL);
>  			for (entry_record = HEAD(ldap_qresult_record->ldap_entries);
>  					entry_record != NULL;
>  					entry_record = NEXT(entry_record, link)) {
> -- 
> 1.7.11.4
> 


-- 
Adam Tkac, Red Hat, Inc.