[Freeipa-devel] [PATCH] Simplify get_group_sids

Sumit Bose sbose at redhat.com
Mon Sep 24 19:52:00 UTC 2012


On Mon, Sep 24, 2012 at 02:40:45PM -0400, Simo Sorce wrote:
> 
> This should also give us a slight performance boost as we do
> not convert the whole SID to a string many times over.
> 

I was digging up the archive URL of my patch related to this posted to
the list on July
(https://www.redhat.com/archives/freeipa-devel/2012-July/msg00089.html)
when I realized that you already reviewed it and gave some comments
(https://www.redhat.com/archives/freeipa-devel/2012-July/msg00132.html). For
some reasons this mail never made it into my inbox.

Since the old patch does not only covers the SID to string conversion
but adds other improvements to memory allocation I would like to ask if
you can ACK the old one if I fix the issues you mentioend in your
comment and drop yours instead?

bye,
Sumit

> Simo.
> 
> -- 
> Simo Sorce * Red Hat, Inc. * New York




More information about the Freeipa-devel mailing list