[Freeipa-devel] [PATCH 0015] Restrict admins group modifications

[Tomas Babej]

On 09/25/2012 02:31 PM, Martin Kosek wrote:
> On 09/25/2012 02:22 PM, Tomas Babej wrote:
>> Hi,
>>
>> Group-mod command no longer allows --rename and/or --external
>> changes made to the admins group. In such cases, ProtectedEntryError
>> is being raised.
>>
>> https://fedorahosted.org/freeipa/ticket/3098
>>
>> Tomas
>>
> Just based on a quick glance, I see few issues:
>
> 1) I would like to see unit tests for this scenario
>
> 2) Some overlooked debug output:
>
> +        self.log.info(str(keys))
>
> Martin
I removed the unfortunate debug output and added two unit tests to test 
the scenarios.

Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0015-2-Restrict-admins-group-modifications.patch
Type: text/x-patch
Size: 4666 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120925/cc227e03/attachment.bin>