[Freeipa-devel] [PATCH] 0012 Fix output for some CLI commands

Ana Krivokapic akrivoka at redhat.com
Mon Apr 8 16:15:28 UTC 2013


On 04/08/2013 04:33 PM, Jan Cholasta wrote:
> On 8.4.2013 15:41, Jan Cholasta wrote:
>> Hi,
>>
>> On 8.4.2013 13:40, Ana Krivokapic wrote:
>>> Hello,
>>>
>>> This patch addresses https://fedorahosted.org/freeipa/ticket/3503. See
>>> the commit message for details.
>>>
>>
>> the patch seems OK, I will just run the test suite to make sure you
>> didn't miss anything.
>>
>> Honza
>>
>
> Change dnszone_del summary to "Deleted DNS zone", as we use "DNS zone"
> (not just "zone") in other commands. Also as Petr pointed out, we're
> in string freeze now, so we have to wait until it's over before
> pushing this patch, or split the patch in two.
>
> Besides that, ACK.
>

Thanks for the review.

I have changed the summary message to "Deleted DNS zone", and split the
patch into two patches that can be applied independently.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akrivoka-0012-02-Fix-output-for-some-CLI-commands.patch
Type: text/x-patch
Size: 10685 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130408/7059ed7c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akrivoka-0013-Add-missing-summary-message-to-dnszone_del.patch
Type: text/x-patch
Size: 2590 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130408/7059ed7c/attachment-0001.bin>


More information about the Freeipa-devel mailing list