[Freeipa-devel] [PATCHES] 206-209 Add default CFLAGS & fix hardened build

[Petr Viktorin]

On 12/05/2013 11:15 AM, Jan Cholasta wrote:
> Hi,
>
> the attached patches fix <https://fedorahosted.org/freeipa/ticket/3896>.
>
> Patch 207 should fix build failures some of you were having after
> hardenening was enabled in the spec file.

Thanks!

In 209, would (ret != 1) make more sense than (ret == -1)? AFAIU zero 
would also indicate a problem, if it somehow ended up being returned.


It seems though the hardening flags get included twice. I assume that's 
not a problem? I get lines like:

gcc -DHAVE_CONFIG_H -I. -I..   -I/usr/include/nspr4  -I/usr/include/nss3 
-I/usr/include/nspr4
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions 
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-m64 -mtune=generic -g -O2 -Werror -Wall -Wextra -Wformat-security 
-Wno-unused-parameter -Wno-sign-compare -Wno-missing-field-initializers
-DWITH_OPENLDAP -I/usr/include/nspr4  -I/usr/include/nss3 
-I/usr/include/nspr4  -DUSE_OPENLDAP
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions 
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-m64 -mtune=generic -g -O2 -Werror -Wall -Wextra -Wformat-security 
-Wno-unused-parameter -Wno-sign-compare -Wno-missing-field-initializers
-MT parse.o -MD -MP -MF .deps/parse.Tpo -c -o parse.o parse.c


gcc -DHAVE_CONFIG_H -I.  -I. -I. -I../util -DPREFIX=\""/usr"\" 
-DBINDIR=\""/usr/bin"\" -DLIBDIR=\""/usr/lib64"\" 
-DLIBEXECDIR=\""/usr/libexec"\"
-DDATADIR=\""/usr/share"\" -DLOCALEDIR=\""/usr/share/locale"\"  -Wall 
-Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-align 
-Werror-implicit-function-declaration
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions 
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic
-Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-align 
-Werror-implicit-function-declaration
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions 
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches 
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic
-g -O2 -Werror -Wall -Wextra -Wformat-security -Wno-unused-parameter 
-Wno-sign-compare -Wno-missing-field-initializers
-MT ipa-getkeytab.o -MD -MP -MF .deps/ipa-getkeytab.Tpo -c -o 
ipa-getkeytab.o ipa-getkeytab.c


-- 
Petr³