[Freeipa-devel] [PATCH] 211 Fix internal error in the user-status command

Petr Viktorin pviktori at redhat.com
Tue Dec 10 14:35:33 UTC 2013


On 12/10/2013 03:23 PM, Jan Cholasta wrote:
> On 10.12.2013 15:18, Petr Viktorin wrote:
>> On 12/10/2013 02:15 PM, Jan Cholasta wrote:
>>> On 10.12.2013 12:18, Petr Viktorin wrote:
>>>> On 12/05/2013 02:45 PM, Jan Cholasta wrote:
>>>>> Hi,
>>>>>
>>>>> the attached patch fixes
>>>>> <https://fedorahosted.org/freeipa/ticket/4066>.
>>>>>
>>>>> Honza
>>>>
>>>> Patch looks good, ACK.
>>>>
>>>> I've added a small regression test for this, does it look OK?
>>>
>>> Thanks, it looks OK except I don't see "dn" in result and I would rename
>>> "isodate_re" to "generalizedtime_re".
>>
>> Your patch adds "dn".
>
> Oh, right.
>
>>
>> user_status without --raw will report time in ISO 8601
>> (%Y-%m-%dT%H:%M:%SZ). GeneralizedTime would be "%Y%m%d%H%M%SZ".
>>
>
> Also right.
>
> Sorry for the fuss then, ACK.
>

Thanks, pushed both to master: b6563984154e577cdf430f8f74f15f912ac0ee12

-- 
Petr³




More information about the Freeipa-devel mailing list