[Freeipa-devel] [PATCH] 259 Combobox keyboard support

[Petr Vobornik]

On 03/02/2013 08:38 PM, Endi Sukma Dewata wrote:
> On 02/27/2013 06:54 AM, Petr Vobornik wrote:
>> On 02/27/2013 01:50 AM, Endi Sukma Dewata wrote:

>>
>>> Another minor thing, if the search box is in focus, you can use the
>>> Up/Down arrow to go to the list. However, from the list you cannot
>>> use the Up/Down arrow to go back to the search box, you'd have to use
>>> the Tab key. It's not really a problem, but it's not that consistent.
>> Up/Down keys are natural way of changing value of a list - this part
>> seems OK to me. So Up/Down arrow in search box might the problem, but
>> I consider it a feature - saves some strokes. Also, User can always
>> use tab to switch between search box and list.
>
> I'm OK with the Up/Down arrow in search box too, but if it's not
> consistent people may think it's a bug.  So I'd suggest we make it such
> that you can use Up/Down to go back to the search box.

Up/Down doesn't just go to the list but it also changes the selected 
item in the list. So we might say that it's consistent - it changes 
selected item.

I might agree that going from search box to list is wrong or misleading 
but I'm strongly against going back to search box using Up/Down keys. It 
would be redefining of implicit behavior of select element.

>
> All of the above are minor. The patch itself is ACKed.
>
Anyway, pushed to master

-- 
Petr Vobornik