[Freeipa-devel] [PATCH] 255 Added Web UI support for service PAC type option: NONE

[Petr Vobornik]

On 02/14/2013 04:56 PM, Endi Sukma Dewata wrote:
> On 2/14/2013 6:30 AM, Petr Vobornik wrote:
>>> If they are mutually exclusive, they probably should be separated using
>>> radio buttons like this:
>>>
>>>    PAC: ( ) None
>>>         (o) Type:
>>>             [x] MS-PAC
>>>             [ ] PAD
>>
>> You missed one option: nothing selected. It can be solved by adding   '(
>> ) Inherited' radio.
>
> I wouldn't have guessed that :) I agree we should add the 'Inherited'
> option.
>
>> Anyway, this design seems more user friendly for more general audience
>> than mine so I will implement it. The only problem with it is that one
>> have to come with new label for each group and empty value - can't be
>> inferred from metadata.
>
> Is there any issue adding new labels at this point? Worst case we could
> hard code the label now and add a translation later.
>
>>> It might be better to use a composite widget of radio buttons and
>>> checkboxes so we can reuse the code. Probably the definition will look
>>> something like this:
>>>
>>> {
>>>      name: 'ipakrbauthzdata',
>>>      type: 'radio',
>>
>> Not sure if it should be radio, more like something new.
>
> Right, probably the current radio widget can't do this. So either we
> improve the radio widget or create something new.
>
>>>      label: ...,
>>>      options: [
>>>          {
>>>              label: ...,
>>>              value: 'NONE'
>>>          },
>>>          {
>>>              label: ...,
>>>              type: 'checkboxes',
>>
>> Do you expect to be there something different than checkboxes, or do you
>> want it to do it this way for possible future customization.
>
> Ideally it should be generic enough to combine any widgets. This might
> be a common scenario somewhere else:
>
> Something: ( ) Option 1
>             ( ) Option 2
>             (o) Other: [something else       ]
>

This design has a flaw: 
https://fedorahosted.org/freeipa/ticket/3404#comment:5

I implemented following design: 
https://fedorahosted.org/freeipa/ticket/3404#comment:7

Patch attached (255-1).

I have a dilemma. I practically implemented the previous design (and 
then I've found the flaw..). Patches attached as wip-fre... I wonder if 
we can use it somehow or we should ditch it.

-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0255-1-Added-Web-UI-support-for-service-PAC-type-option-NON.patch
Type: text/x-patch
Size: 7379 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130307/24531b75/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wip-freeipa-pvoborni-0457-Added-Web-UI-support-for-service-PAC-type-option-NON.patch
Type: text/x-patch
Size: 1268 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130307/24531b75/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wip-freeipa-pvoborni-0458-Nesteble-checkboxes-radions-initial-implementation.patch
Type: text/x-patch
Size: 24564 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130307/24531b75/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wip-freeipa-pvoborni-0459-Multivalued-widget.patch
Type: text/x-patch
Size: 5177 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130307/24531b75/attachment-0003.bin>